Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Aug 5, 2025

Changelog

We now order outputs of authentication information from the doctor command according to an alphabetized list of team domains.

Summary

This PR orders authentications by team domain in doctor command outputs.

Preview

$ slack doctor
    ✔ Credentials (your Slack authentication)
        Team domain: slackbox-ez
        Team ID: T02A074M3U3
        User ID: U04051AF9NJ
        Last updated: 2025-08-04 17:31:48 -07:00
        Authorization level: Workspace
        Token status: Valid

        Team domain: tinyspek
        Team ID: E06LPMFSSTU
        User ID: U06MCF88LQY
        Last updated: 2025-08-04 17:31:48 -07:00
        Authorization level: Organization
        Token status: Valid

Reviewers

$ slack login   # Login to a workspace
$ slack login   # Login to an organization
$ slack doctor  # Run a checkup
$ slack doctor  # Find matching outputs

Requirements

@zimeg zimeg added this to the Next Release milestone Aug 5, 2025
@zimeg zimeg self-assigned this Aug 5, 2025
@zimeg zimeg requested a review from a team as a code owner August 5, 2025 06:58
@zimeg zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment labels Aug 5, 2025
@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.02%. Comparing base (6a9e147) to head (779d5ff).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   62.97%   63.02%   +0.04%     
==========================================
  Files         212      212              
  Lines       21585    21608      +23     
==========================================
+ Hits        13594    13619      +25     
+ Misses       6945     6944       -1     
+ Partials     1046     1045       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg
Copy link
Member Author

zimeg commented Aug 5, 2025

@hello-ashleyintech No rush at all but a kind request for review in noticing these changes needed 🙏 ✨

Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@zimeg
Copy link
Member Author

zimeg commented Aug 6, 2025

@hello-ashleyintech This is great to find - thank you for the review. 👾

I'm going to merge this now so we can find this for the next release! 🚢 💨

@zimeg zimeg merged commit 9d70e50 into main Aug 6, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-fix-doctors-order branch August 6, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants