-
Notifications
You must be signed in to change notification settings - Fork 24
Docs: updates links to point to docs.slack.dev/tools* paths
#176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 63.02% 63.03% +0.01%
==========================================
Files 212 212
Lines 21608 21608
==========================================
+ Hits 13618 13621 +3
+ Misses 6943 6942 -1
+ Partials 1047 1045 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just dropping a quick change request to avoid this being merged by accident. We'll want to undo the changes to the download URLs.
|
|
||
| ```zsh | ||
| curl -fsSL https://downloads.slack-edge.com/slack-cli/install.sh | bash | ||
| curl -fsSL https://downloads.slack-edge.com/tools/slack-cli/install.sh | bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to change this URL because our download URL is not changing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes my bad i thought i undid all these
|
👍🏻 Everything else is looking good! We'll just want to undo that one line and then we can merge away! |
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Thanks a bunch for the updates! Looks good to me. ![]()
Summary
tools pages are being directed to docs.slack.dev/tools moving forward. This readies the links for that
Requirements