Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Apr 7, 2025

Summary

This PR changes the label @dependabot uses from code health to build as part of this new label 🏷️ ✨

Notes

This is a follow up from the following: πŸ“š

https://github.com/slackapi/slack-cli/blob/main/.github/MAINTAINERS_GUIDE.md#issue-management

build: A change to the build, compile, or CI/CD pipeline.

Requirements

@zimeg zimeg added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Apr 7, 2025
@zimeg zimeg added this to the Next Release milestone Apr 7, 2025
@zimeg zimeg self-assigned this Apr 7, 2025
@zimeg zimeg requested a review from a team as a code owner April 7, 2025 23:32
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… LGTM! What are your thoughts on a semver:patch label as well? It's not always guaranteed to be accurate, but it would the majority of the time.

@zimeg
Copy link
Member Author

zimeg commented Apr 8, 2025

@mwbrooks Great call! I'll include that with these changes since that does seem to be the most common case and it's no trouble updating the tag as needed πŸ€– ✨

@zimeg zimeg changed the title ci: label dependabot changes as 'build' in pull requests ci: label dependabot changes as 'build' patch changes in pull requests Apr 8, 2025
@zimeg
Copy link
Member Author

zimeg commented Apr 8, 2025

πŸ“ I checked if setting the Milestone to "Next Release" was possible too, but it doesn't seem so...

You must specify the numeric identifier of the milestone and not its label.

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/customizing-dependabot-prs#associating-pull-requests-with-a-milestone

@zimeg
Copy link
Member Author

zimeg commented Apr 8, 2025

@mwbrooks Thanks once again for this review! I will merge this PR now that tests are passing πŸ‘

@zimeg zimeg merged commit c2e4e79 into main Apr 8, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-chore-dependabout-label branch April 8, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build M-T: Changes to compilation and CI processes code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants