Skip to content

Conversation

@mwbrooks
Copy link
Member

@mwbrooks mwbrooks commented Apr 9, 2025

Summary

This pull request updates the README.md by removing the token from the CircleCI status badge. The token was required for private repos, but no longer required because we've now a public, open sourced project 🎉 🥳

The token is only used for the status badge, so there's no security concern that it's part of our commit history.

Reviewers

  • Preview README.md
    • If you're logged into CircleCI, you can open this link in an Incognito browser window

Requirements

@mwbrooks mwbrooks added docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment labels Apr 9, 2025
@mwbrooks mwbrooks added this to the Next Release milestone Apr 9, 2025
@mwbrooks mwbrooks self-assigned this Apr 9, 2025
@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.95%. Comparing base (1482e2e) to head (9644370).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   62.79%   62.95%   +0.16%     
==========================================
  Files         210      210              
  Lines       22053    22127      +74     
==========================================
+ Hits        13848    13930      +82     
+ Misses       7126     7111      -15     
- Partials     1079     1086       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks marked this pull request as ready for review April 9, 2025 19:24
@mwbrooks mwbrooks requested a review from a team as a code owner April 9, 2025 19:24
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks LGTM and thank you for keeping a note of this change. This is another link for my bookmarks 🏷️✨

@mwbrooks
Copy link
Member Author

mwbrooks commented Apr 9, 2025

Thanks for the eyes @zimeg! If you have a way for SVG badges to appear on browser bookmarks, I wanna see it! 📛

@mwbrooks mwbrooks merged commit 95e061d into main Apr 9, 2025
6 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-readme-status-badges branch April 9, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants