Skip to content

Conversation

@lukegalbraithrussell
Copy link
Contributor

Summary

This makes it an external link so we no longer need to host the image, which is creating an issue with the docs syncing.

Requirements

@lukegalbraithrussell lukegalbraithrussell requested a review from a team as a code owner April 10, 2025 18:59
@mwbrooks mwbrooks added docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment labels Apr 10, 2025
@mwbrooks mwbrooks added this to the Next Release milestone Apr 10, 2025
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.92%. Comparing base (95e061d) to head (d6d8895).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   62.95%   62.92%   -0.04%     
==========================================
  Files         210      210              
  Lines       22127    22127              
==========================================
- Hits        13930    13923       -7     
- Misses       7111     7119       +8     
+ Partials     1086     1085       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks for fixing the sync issue. It's too bad that we can't keep it generic, but that's alright. If we update the logo, we may need to update the URL as well. 🔗

@mwbrooks mwbrooks changed the title Docs: changes readme logo to github hosted pic docs: fix sync issue by updating README.md logo to use GitHub URL Apr 10, 2025
@lukegalbraithrussell lukegalbraithrussell merged commit c335c36 into main Apr 10, 2025
6 checks passed
@lukegalbraithrussell lukegalbraithrussell deleted the docs-change-readme-picture-link branch April 10, 2025 19:07
@zimeg
Copy link
Member

zimeg commented Apr 10, 2025

🤔 Do we want to follow up and remove the .svg from source code too? I think we can checkout one of these earlier commits as needed but I'm not sure that we're referencing it elsewhere

@lukegalbraithrussell
Copy link
Contributor Author

@zimeg It gets removed in the sync PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants