fix: gather version for windows installation from latest releases metadata#297
fix: gather version for windows installation from latest releases metadata#297
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
=======================================
Coverage 64.87% 64.87%
=======================================
Files 213 213
Lines 17550 17550
=======================================
+ Hits 11385 11386 +1
+ Misses 5101 5099 -2
- Partials 1064 1065 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WilliamBergamin
left a comment
There was a problem hiding this comment.
Any way we could add CI tests for this script somehow? 🤔
|
@cchensh @WilliamBergamin @srtaalej Thanks so much for the quick reviews 🙏 ✨
Before merging this, I'll look into adding a few Windows tests to this PR. Thank you for calling this out - it's still not clear to me when this started to fail without such! 👾 |
|
🤖 issue: Windows in CI is difficult to test I'm finding... I reverted the testing attempts in this PR and find that these scripts work on a personal machine so I'll merge this. 🗣️ ramble: The issue of CI testing isn't clear to me but seems related to updating the path to the installation within the script and with some CI specific settings. I have note to follow up on this if new insights appear! |
Summary
This PR gathers the latest version for Windows installations from the releases metadata now found at:
🔗 https://docs.slack.dev/tools/metadata.json
This fixes #296 which might've relied on multiple entries of releases beforehand 🤔
Requirements