ci: escape pull request branch tag before creating releases to test #38
Conversation
zimeg
added
semver:patch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 62.92% 62.91% -0.02%
==========================================
Files 210 210
Lines 22149 22149
==========================================
- Hits 13937 13934 -3
- Misses 7126 7129 +3
Partials 1086 1086 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📝 Since this PR is created on a forked branch, the required "build-lint-test-e2e-test" workflow does not start. Changes in #36 let us start this after a review:
|
does this also start the unit tests from a fork branch?
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
🧪 A few notes on these changes for the kind reviewer while tests run:
| BRANCH_NAME=$(echo "<< parameters.release_ref >>" | sed 's/\//-/g') | ||
| RELEASE_REF="${LAST_SEMVER_TAG}-${BRANCH_NAME}" |
There was a problem hiding this comment.
📝 This replaces / with - as if the slash stretches between words. This makes a valid semantic version.
| if [[ -z "$CIRCLE_BRANCH" || "$CIRCLE_BRANCH" == pull/* ]]; then | ||
| BRANCH_NAME="main" | ||
| echo "Performing the standard end-to-end test suite for changes of a forked branch" | ||
| else | ||
| BRANCH_NAME="$CIRCLE_BRANCH" | ||
| fi |
There was a problem hiding this comment.
📝 Changes the E2E tests are not with this repo so we are defaulting to the main branch.
This is required since matching PR numbers might or might not exist upstream which can cause unexpected testing behavior!
There was a problem hiding this comment.
📝 I am making a note that this is worth mentioning in the changes of #36!
| BRANCH_NAME=$(echo "<< parameters.release_ref >>" | sed 's/\//-/g') | ||
| RELEASE_REF="${LAST_SEMVER_TAG}-${BRANCH_NAME}" |
|
@mwbrooks Thanks so much! I'm hoping this'll make prereleases a bit-more-pleasant-to-read 👾 |
2 participants
Summary
This PR escapes the branch name of pull requests for use in tests started with #36.
Preview
v3.0.4-pull/38/headv3.0.4-pull-38-headRequirements