ci: delete pre-releases matching existing or escaped tags#40
ci: delete pre-releases matching existing or escaped tags#40zimeg merged 18 commits intoslackapi:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 62.91% 62.93% +0.02%
==========================================
Files 210 210
Lines 22149 22149
==========================================
+ Hits 13934 13940 +6
+ Misses 7129 7125 -4
+ Partials 1086 1084 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
✅ LGTM! Thanks for continuing to tighten up our external contributor process! ✨
for some reason the tests still did not start on a forked pr
|
@mwbrooks Thanks so much too for the review 🙏 ✨ I was exploring a lot of unrelated changes in this PR that branched into #42 and #44. These both attempt to address the E2E tests not running for this PR, but AFACT that is instead related to changes of the For now I'm wanting to merge this change to test the actual deletion of this branch. I'll report back with findings, and if all goes well I'll cleanup a few releases made from previous tests. |
|
📣 So close. The branch deletion event starts workflows on the fork. This makes sense but also might require a follow up PR. I'll check one more thing before that. Deleting a release or existing tag might start the workflow on this upstream. I'll check both, but follow up still seems needed in either case 👀 |
|
📝 This workflow starts if a tag is deleted. Not slack-cli/.github/workflows/delete-pr-build-on-close.yml Lines 6 to 8 in b939841 I think the |
|
📝 We are also escaping the branch name of a pull request as expected here! I'm thinking another event might let us used the status of a closed PR to run this workflow when merging forked PRs: https://github.com/slackapi/slack-cli/actions/runs/14525840455/job/40757068833 |
Summary
This PR deletes prereleases created from forked pull requests after the branch is deleted.
Preview
Two separate but related issues of lingering prereleases are fixed here:
Dashes to slashes
Forked tag prefixes
Requirements