fix: 'upgrade' output includes SDK when inside a project dir#46
fix: 'upgrade' output includes SDK when inside a project dir#46zimeg merged 3 commits intoslackapi:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 62.93% 62.89% -0.05%
==========================================
Files 210 210
Lines 22147 22152 +5
==========================================
- Hits 13938 13932 -6
- Misses 7126 7134 +8
- Partials 1083 1086 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mwbrooks Thanks so much for sharing these previews 📺 ✨ I'm eager to merge this now but am wanting to check one or two more things with tests before so. One strange thing happening on the latest commit I notice is two runs of E2E test status. AFAICT this is from other experiments unrelated. Another unrelated test change relates to cleaning up the artifacts used in testing forked changes after a merge! |
|
@mwbrooks Thanks yet again for a review and preview. Tests are passing as we might hope for these changes. I will merge this now for the next release with hopes that this next |


Summary
This PR updates outputs of the
upgradecommand to note if the latest SDK versions were checked.Preview
Outputs now change depending on the path used 👾
$ slack version Using slack v3.0.4 $ slack upgrade ✔ You are using the latest Slack CLI version $ slack create asdf $ cd asdf $ slack upgrade ✔ You are using the latest Slack CLI and SDK versionsReviewers
A handbuilt make of these changes might be useful for testing the shown version:
And these commands can be useful in testing cases with a
boltJS project:Requirements