ci: delete testing fork pre-releases using upstream tag names#48
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 62.89% 62.89%
=======================================
Files 210 210
Lines 22147 22147
=======================================
Hits 13930 13930
Misses 7129 7129
Partials 1088 1088 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📝 Commit 7593a1b logs the https://github.com/slackapi/slack-cli/actions/runs/14526446447/job/40758810974?pr=48 |
|
📝 Commit e4dce67 logs the https://github.com/slackapi/slack-cli/actions/runs/14526503952/job/40758962739?pr=44 |
|
📝 For reference of both above changes, existing prereleases follow similar patterns that'd be matched using semver prefixes: |
zimeg
left a comment
There was a problem hiding this comment.
📣 A note on changes and findings in tests are included in comments both above and below for the kind reviewers.
| pull_request: | ||
| types: | ||
| - closed |
There was a problem hiding this comment.
🔗 Attached is a link on running after PR merge:
There was a problem hiding this comment.
📝 An update removed the check that the PR merged since we're wanting to delete these pre-releases after any PR closes I believe
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Nice and great approach to bringing both branch names into alignment!
|
@mwbrooks Thanks so much. 🎁 I'm not so thrilled with the added lines here, but I believe this now lets us test branches from forks using pre-releases and clean things up afterwards. Let's test this in a few PRs soon though! |
|
📣 This PR pre-release was found and deleted! |
|
🤔 A deleted PR from a forked branch failed: Which might be due to the
|
Summary
This PR uses either an upstream or fork PR branch when deleting a pre-release after a pull request is merged.
Fixes an issue where upstream tag names use different convention from forks and also where this workflow runs.
Requirements