Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/delete-pr-build-on-close.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ jobs:
delete-pre-release:
name: Delete pre-release if exists
runs-on: ubuntu-latest
permissions:
contents: write
Comment on lines +24 to +25
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

steps:
- name: Delete pre-release and tag named after branch
env:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/dependencies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ jobs:
golang:
name: Bump the Golang version
runs-on: ubuntu-latest
permissions:
contents: none # Permissions are set with an application token
Comment on lines +10 to +11
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 The application token is included when needed, and it remains possible to start the job. We might have to wait for an actual update to confirm this though:

https://github.com/slackapi/slack-cli/actions/runs/14578846863/job/40890875279

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 More notes on these permissions are included in the MAINTAINERS_GUIDE.md!

https://github.com/slackapi/slack-cli/blob/main/.github/MAINTAINERS_GUIDE.md#bumping-the-golang-version

steps:
- name: Gather credentials
id: credentials
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/e2e_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
execute:
name: Start tests
runs-on: ubuntu-latest
permissions:
contents: none
Comment on lines +20 to +21
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 Permissions are handled within CircleCI for this workflow:

https://github.com/slackapi/slack-cli/runs/40890474475

steps:
- name: Trigger CircleCI 'local' workflow
if: ${{ github.event.inputs.status == 'false' }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/license_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ jobs:
check-headers:
name: Check that license headers are in place
runs-on: ubuntu-latest
permissions:
contents: read
Comment on lines +13 to +14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 This is enough to cause the LICENSE checks to fail when needed - 6591d1f causes:

https://github.com/slackapi/slack-cli/actions/runs/14578766377/job/40890636282?pr=54

steps:
- uses: actions/checkout@v4.2.2
with:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/sync-docs-from-cli-repo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ jobs:
config-sync:
name: Sync docs to docs site repo
runs-on: ubuntu-latest

permissions:
contents: read
Comment on lines +20 to +21
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 Checking out the repo is all that's required with the default token!

An application token helps with other permissions. Testing after the changes of #52-

steps:
- name: Generate a GitHub token
id: ghtoken
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
lint-test:
name: Lints and Unit tests
runs-on: macos-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v4.2.2
with:
Expand Down Expand Up @@ -49,6 +51,8 @@ jobs:
health-score:
needs: lint-test
runs-on: macos-latest
permissions:
checks: write
steps:
- uses: actions/checkout@v4.2.2
- name: Set up Go
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changelog - a log of changes

1. commit this file for testing a license workflow
Loading