Skip to content

ci: include compiled archives in snapshot build releases #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 8 commits into from
Apr 3, 2025
Merged

ci: include compiled archives in snapshot build releases #6

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
19f93c5
ci: exit with error if development or production archive builds fail
zimeg Apr 2, 2025
6078ccd
ci: exit with error from within the archive script not circle
zimeg Apr 2, 2025
ec20fcd
ci: use the most recent commit hash in changelog if no tag exists
zimeg Apr 2, 2025
cc496f3
ci: match prior feature builds when gathering the git version
zimeg Apr 2, 2025
70e8223
ci: share production compilation flags with the snapshot build
zimeg Apr 2, 2025
3e3cf9f
revert: remove adjacent updates to ci for more focused changes
zimeg Apr 2, 2025
d1e5f51
chore: merge w main
zimeg Apr 2, 2025
67bc246
style: avoid exporting ldflags used in the build snapshot step
zimeg Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ jobs:
- run:
name: Run GoReleaser. Without actually publishing.
command: |
export LDFLAGS="-s -w -X 'github.com/slackapi/slack-cli/internal/pkg/version.Version=$BUILD_VERSION'"
make build-snapshot
LDFLAGS="-s -w -X 'github.com/slackapi/slack-cli/internal/pkg/version.Version=$BUILD_VERSION'"
make LDFLAGS="$LDFLAGS" build-snapshot
Copy link
Member Author

@zimeg zimeg Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -s and -w flag weren't being used when building the snapshot! I'm hoping this improves our runtime speeds around 👾

Before:

$ du dist/*
...
13324   dist/slack_cli_3.0.2-main-build-test-feature-6-gcc496f3_linux_64-bit.tar.gz
13332   dist/slack_cli_3.0.2-main-build-test-feature-6-gcc496f3_macOS_64-bit.tar.gz
14376   dist/slack_cli_3.0.2-main-build-test-feature-6-gcc496f3_windows_64-bit.zip

After:

$ du dist/*
...
7156    dist/slack_cli_3.0.2-main-build-test-feature-6-gcc496f3_linux_64-bit.tar.gz
7252    dist/slack_cli_3.0.2-main-build-test-feature-6-gcc496f3_macOS_64-bit.tar.gz
7208    dist/slack_cli_3.0.2-main-build-test-feature-6-gcc496f3_windows_64-bit.zip

Copy link
Member

@mwbrooks mwbrooks Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @zimeg! 👏🏻 Before this change, the export LDFLAGS was unused and instead it was using the LDFLAGS set by Makefile's startup.

- run:
name: Show binaries are generated correctly
command: ls -R ./dist
Expand Down
Loading