Skip to content

Conversation

@amarinelli
Copy link
Member

Summary

Small update to fix example command references which were not using double hyphen for org workspace grant flag.

Requirements

@amarinelli amarinelli requested a review from a team as a code owner April 25, 2025 15:51
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.56%. Comparing base (b6953db) to head (7d149ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   63.59%   63.56%   -0.03%     
==========================================
  Files         212      212              
  Lines       22398    22398              
==========================================
- Hits        14244    14238       -6     
- Misses       7072     7074       +2     
- Partials     1082     1086       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amarinelli amarinelli added the docs M-T: Documentation work only label Apr 25, 2025
@zimeg zimeg changed the title Fix example command references in enterprise docs docs: fix example command references in enterprise docs Apr 25, 2025
@zimeg
Copy link
Member

zimeg commented Apr 25, 2025

@amarinelli Super sharp eye! Thanks for catching this and sharing a fix so fast 👁️‍🗨️ ✨

I am noticing the docs workflow is not sharing secrets with branches of a fork though! 🤔

@lukegalbraithrussell I'm wondering if we'll want to run this workflow in an environment to build the site with tokens? IMO it is important to have "successful" checks before a merge.

The slackapi/slack-github-action uses this approach to run tests with IRL Slack tokens as a possible reference!

@zimeg zimeg added the semver:patch Use on pull requests to describe the release version increment label Apr 25, 2025
@zimeg zimeg added this to the Next Release milestone Apr 25, 2025
@mwbrooks mwbrooks self-assigned this Apr 25, 2025
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 Yay, thanks for the fix @amarinelli!

💯 Agree with @zimeg that we want to see our GitHub Checks to passing before merging these PRs. This seems like a good PR to work out the kinks.

@mwbrooks mwbrooks assigned zimeg and unassigned mwbrooks Apr 25, 2025
@amarinelli
Copy link
Member Author

Thanks, all! I noticed the failure and was reading through contributor/maintainer docs to see if that was on me to build the docs or similar. Let me know if there is any actions I need to take now or next time.

@lukegalbraithrussell
Copy link
Contributor

@amarinelli Yeah this is a docs ci edge case I didn't think about. Nothing for you to do rn -- I'm looking into a solution today going off @zimeg's suggestions

@mwbrooks mwbrooks modified the milestones: v3.1.0, Next Release May 2, 2025
@mwbrooks mwbrooks modified the milestones: v3.2.0, Next Release May 16, 2025
@mwbrooks mwbrooks modified the milestones: v3.3.0, Next Release May 30, 2025
@mwbrooks mwbrooks modified the milestones: v3.4.0, Next Release Jun 13, 2025
@zimeg zimeg modified the milestones: v3.5.0, Next Release Jun 27, 2025
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amarinelli @mwbrooks @lukegalbraithrussell Sharing from the silence on changes behind the scenes!

#145 removed the syncing workflow that was blocking tests from running as expected here, so we can now merge this with confidence 📚 ✨

@zimeg zimeg merged commit 2484046 into slackapi:main Jun 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants