-
Notifications
You must be signed in to change notification settings - Fork 24
docs: fix example command references in enterprise docs #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 63.59% 63.56% -0.03%
==========================================
Files 212 212
Lines 22398 22398
==========================================
- Hits 14244 14238 -6
- Misses 7072 7074 +2
- Partials 1082 1086 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@amarinelli Super sharp eye! Thanks for catching this and sharing a fix so fast 👁️🗨️ ✨ I am noticing the @lukegalbraithrussell I'm wondering if we'll want to run this workflow in an The |
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏻 Yay, thanks for the fix @amarinelli!
💯 Agree with @zimeg that we want to see our GitHub Checks to passing before merging these PRs. This seems like a good PR to work out the kinks.
|
Thanks, all! I noticed the failure and was reading through contributor/maintainer docs to see if that was on me to build the docs or similar. Let me know if there is any actions I need to take now or next time. |
|
@amarinelli Yeah this is a docs ci edge case I didn't think about. Nothing for you to do rn -- I'm looking into a solution today going off @zimeg's suggestions |
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amarinelli @mwbrooks @lukegalbraithrussell Sharing from the silence on changes behind the scenes!
#145 removed the syncing workflow that was blocking tests from running as expected here, so we can now merge this with confidence 📚 ✨
Summary
Small update to fix example command references which were not using double hyphen for org workspace grant flag.
Requirements