refactor: enable linter rule ST1005 for error string formatting

[mwbrooks]

Summary

This pull request enables the linter staticcheck rule ST1005: 'Incorrectly formatted error string'.

In general, it's enforces the following:

• Error strings must start with a lowercase letter, unless a proper name or initialism
  • Unfortunately, I couldn't figure out how to make "Slack" a recognized noun
• Error strings cannot end with punctuation (e.g. periods .)

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.18%. Comparing base (9437aa2) to head (dfcd379).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/auth/auth.go	0.00%	1 Missing ⚠️
internal/pkg/create/create.go	0.00%	1 Missing ⚠️
internal/update/cli_metadata.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   63.19%   63.18%   -0.02%     
==========================================
  Files         210      210              
  Lines       22187    22187              
==========================================
- Hits        14021    14018       -3     
- Misses       7081     7082       +1     
- Partials     1085     1087       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zimeg]

@mwbrooks I'm hesitating on these changes since I'm not sure that we want to use Errorf in general?

Patterns around slackerror with custom messages seem best to me since it allows us to have coded errors, but these changes might be better for another PR.

Please let me know how you're wanting to proceed! 👾 ✨

[mwbrooks]

@zimeg My two-cents is that the code is currently using Errorf and the motivation of this PR is to enable the linter rule for error string formatting. I'd prefer to see this PR enable the linter with the current code, then a follow-up PR that switches the errors from Errorf to slackerror.

What do you think? I can handle the follow-up PR to move to slackerror.

[zimeg]

@mwbrooks Incredible focus once more 👁️‍🗨️

It makes so much sense to make additional changes to errors in a separate PR, meaning this all LGTM! 🤖 ✨

[mwbrooks]

@zimeg Awesome, I agree, I like the continue momentum forward with smaller, focused PRs rather than trying to jump ahead.

I'll resolve the merge conflict, merge this one in, and then look at updating these Errorf to slackerror. I'll probably want your thoughts on the formatting for the slackerror!