refactor: rename clients.APIInterface() to clients.API()

[mwbrooks]

Summary

This pull request renames the function clients.APIInterface() to clients.API().

The motivation is that the name is shorter and more accurate. The clients.API() returns an instance of api.Client that implements the api.APIInterface interface. It doesn't return an interface. Alternatively, we could name it clients.APIClient() but I think we're trying to move away from this naming pattern.

There was no change functionality was changed.

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

Attention: Patch coverage is 69.93007% with 43 lines in your changes missing coverage. Please review.

Project coverage is 63.17%. Comparing base (249fb52) to head (efbba6a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/triggers/access.go	63.33%	11 Missing ⚠️
cmd/function/access.go	62.50%	6 Missing ⚠️
cmd/triggers/triggers.go	40.00%	6 Missing ⚠️
internal/pkg/platform/deploy.go	0.00%	5 Missing ⚠️
internal/pkg/auth/login.go	0.00%	4 Missing ⚠️
internal/shared/clients.go	25.00%	3 Missing ⚠️
internal/pkg/apps/install.go	77.77%	2 Missing ⚠️
cmd/externalauth/remove.go	80.00%	1 Missing ⚠️
cmd/function/prompt.go	0.00%	1 Missing ⚠️
cmd/openformresponse/export.go	50.00%	1 Missing ⚠️
... and 3 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   63.16%   63.17%   +0.01%     
==========================================
  Files         210      210              
  Lines       22187    22186       -1     
==========================================
+ Hits        14014    14016       +2     
  Misses       7086     7086              
+ Partials     1087     1084       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mwbrooks]

A few comments to help clear up some noisy diffs! 🧘🏻

[mwbrooks]

There are 3 changes here:

1. Renamed APIInterface → API
2. Alphabetically ordered these fields
3. Removed newline breaks and unnecessary comments so indentation aligns

[zimeg]

Meant to send this with the review prior, but thank you so very much! This is a great PR to make such a change 😌 🎉

[zimeg]

@mwbrooks Less code is better so often! 🏆

While we're updating this would it be best to make a similar change to tests?

slack-cli/internal/shared/clients_mock.go

Line 35 in aabed5e

APIInterface *api.APIMock

[mwbrooks]

note: Update ClientsMock.APIInterface to ClientsMock.API in commit 54da648

[mwbrooks]

@mwbrooks Less code is better so often! 🏆

While we're updating this would it be best to make a similar change to tests?

slack-cli/internal/shared/clients_mock.go

Line 35 in aabed5e

APIInterface *api.APIMock

@zimeg Great catch! I'm a little disappointed in myself for not catching this - I looked through the test and mocks, but overlooked this change.

Commit 54da648 updates the ClientsMock.APIInterface to ClientsMock.API. I used a Find/ReplaceAll on clientsMock.APIInterface, cm.APIInterface, and a few manual changes in the clients_mock.go. It's a MASSIVE change list, but an easy scroll. I didn't notice anything amuck, but I'd appreciate it if you could take a look as well! 🙇🏻

[mwbrooks]

@zimeg Sorry to keep adding more to this PR, but commit efbba6a also updates a defaultAPIInterfaceFunc reference (and removes a TODO comment).

[zimeg]

@mwbrooks You are so fast! 👾 ✨

All of these changes look great and I'm super excited to be using a more refined comments and clients in calling code 👁️‍🗨️

[mwbrooks]

Back at you @zimeg! Thanks for taking the time to review these tedious changes! Ever-so-slowly, things look and feel better.

I'll merge this PR and follow-up with one that updates clients.AuthInterface() to clients.Auth() (should be a lot smaller)