Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Apr 2, 2025

Summary

This PR replaces the "does-not-exist" tag in the dev-build with the most recent related commit 📚

Preview

Before changes:

Full Changelog: v3.0.3...does-not-exist

After changes:

Full Changelog: v3.0.3...a4f5d01

Reviewers

Use the following script to generate matching release notes and confirm the link works: 🔗 ✨

#!/usr/bin/env bash

# https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#generate-release-notes-content-for-a-release--parameters
TARGET=a4f5d015b24214d7001c2549a8b05766ce1aff27
LAST_SEMVER_TAG="v3.0.3"
CHANGELOG=$(curl -L -X POST -v -H "Accept: application/vnd.github+json" -H "Authorization: Bearer $GITHUB_RELEASE_TOKEN" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/slackapi/slack-cli/releases/generate-notes -d "{\"tag_name\":\"${TARGET}\",\"target_commitish\":\"${TARGET}\",\"previous_tag_name\":\"${LAST_SEMVER_TAG}\"}" | jq .body)
echo "Will use release notes: ${CHANGELOG}"
GITHUB_RELEASE_TOKEN=$(gh auth token) ./release.sh
Will use release notes: "<!-- Release notes generated using configuration in .github/release.yml at a4f5d015b24214d7001c2549a8b05766ce1aff27 -->\n\n## What's Changed\n### 🐛 Bug Fixes\n* fix: update broken URL in the hooks.json error message by @mwbrooks in https://github.com/slackapi/slack-cli/pull/3\n### 🧪 Testing/Code Health\n* build(deps): bump golang to 1.24.2 by @slack-cli-releaser in https://github.com/slackapi/slack-cli/pull/5\n* build(deps): bump goreleaser and configurations from v2.5.1 to v2.8.2 by @zimeg in https://github.com/slackapi/slack-cli/pull/4\n\n## New Contributors\n* @slack-cli-releaser made their first contribution in https://github.com/slackapi/slack-cli/pull/5\n* @zimeg made their first contribution in https://github.com/slackapi/slack-cli/pull/4\n\n**Full Changelog**: https://github.com/slackapi/slack-cli/compare/v3.0.3...a4f5d015b24214d7001c2549a8b05766ce1aff27"

v3.0.3...a4f5d01

Requirements

@zimeg zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Apr 2, 2025
@zimeg zimeg added this to the Next Release milestone Apr 2, 2025
@zimeg zimeg self-assigned this Apr 2, 2025
@zimeg zimeg requested a review from a team as a code owner April 2, 2025 23:58
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.79%. Comparing base (a1ee7f9) to head (9cbc220).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   62.79%   62.79%           
=======================================
  Files         210      210           
  Lines       22053    22053           
=======================================
  Hits        13848    13848           
  Misses       7126     7126           
  Partials     1079     1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks changed the title ci: compare the last semver tag and most recent commit in generated release notes ci: fix dev-build GitHub Releases to reference most recent commit in full changelog Apr 3, 2025
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Yay, this is such a nice improvement. Perhaps only we will notice it, but it feels so much better than the does-not-exist tag ✨

@zimeg zimeg requested a review from hello-ashleyintech April 3, 2025 16:47
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice 💖

@zimeg
Copy link
Member Author

zimeg commented Apr 3, 2025

@mwbrooks @hello-ashleyintech Thank you both so much for reviewing 🙏 ✨

I share the excitement for improved development builds and all things related with the hopes that it brings improvement to our releases.

I'm going to merge this now and will check that the updated notes are what we expect. I'll report back 🫡

@zimeg zimeg merged commit fad2c14 into main Apr 3, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-ci-changelog-target branch April 3, 2025 17:26
@zimeg
Copy link
Member Author

zimeg commented Apr 3, 2025

@mwbrooks @hello-ashleyintech Great news! We're now finding commits between tags and the latest of main with the dev-build! 📰

Full Changelog: v3.0.3...fad2c14

@zimeg zimeg added build M-T: Changes to compilation and CI processes and removed code health M-T: Test improvements and anything that improves code health bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build M-T: Changes to compilation and CI processes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants