Skip to content

Conversation

@mwbrooks
Copy link
Member

Summary

This pull request enables the linter staticcheck rule QF1011: 'Omit redundant type from variable declaration'.

This is a very straight-forward linting rule that we've already been practicing. It just looks like a few redundant type declarations slipped through.

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone May 13, 2025
@mwbrooks mwbrooks self-assigned this May 13, 2025
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels May 13, 2025
@mwbrooks mwbrooks marked this pull request as ready for review May 13, 2025 17:30
@mwbrooks mwbrooks requested a review from a team as a code owner May 13, 2025 17:30
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks string 🧵

It's so interesting to me that these are all for filepath.Join! LGTM! I'm also interested in if another linting rule enforces the walrus assignment := over var but that's of course no blocker for this PR 🚢 💨

@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.17%. Comparing base (6f92582) to head (60844b0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/iostreams/logfile.go 66.66% 1 Missing ⚠️
internal/pkg/auth/login.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   63.19%   63.17%   -0.02%     
==========================================
  Files         210      210              
  Lines       22186    22186              
==========================================
- Hits        14020    14017       -3     
- Misses       7081     7083       +2     
- Partials     1085     1086       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks
Copy link
Member Author

It's so interesting to me that these are all for filepath.Join!

I was wondering that myself! Another example of copy & paste spreading the code around?

walrus assignment

😆 Love the name! I haven't noticed a rule, but I hope there is one!

@mwbrooks mwbrooks merged commit 6ffb164 into main May 13, 2025
6 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-lint-qf1011 branch May 13, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants