-
Notifications
You must be signed in to change notification settings - Fork 24
fix: parse the latest deno release in installation script outputs as a tagged version #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse the latest deno release in installation script outputs as a tagged version #91
Conversation
|
Thanks for the contribution! Before we can merge this, we need @haidargit to sign the Salesforce Inc. Contributor License Agreement. |
|
Hey @haidargit! 👋 Thanks so much for catching this and sending in a Before we start review, could you sign the CLA linked from @salesforce-cla? We might have to poke the bot once this is done 😉 |
|
Hi @zimeg 👋, Thanks for the reviews. Sure. I just signed the CLA agreement, but it only shows the message: |
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haidargit Super appreciative of this change! Thanks again for sharing a fix to both the production and development scripts 🙏
I just confirmed this prints both the correct and missing versions as expected:
🔍 Searching for the latest released Deno version... Found: v2.3.1
🔍 Searching for the latest released Deno version... Found: Unknown
For reference of other reviewers, changing the api.github.com URL is sometimes enough to get an unexpected response 👾
More changes to this script might soon follow, but for now this makes for a much better experience. Let's go ahead and merge this for the next release! 🚢 💨
|
📝 But before we merge, I forget that semantic versions don't include the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 63.17% 63.17%
=======================================
Files 210 210
Lines 22186 22186
=======================================
Hits 14017 14017
Misses 7082 7082
Partials 1087 1087 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📝 I took a note that the delete pre-release when a branch is deleted job was stuck in a failed state after reopening this PR for CLA reasons. I'm wondering if we can make this check pass somehow, but for now that ought not be a blocker! |
|
appreciate, @zimeg and other team! Thanks ✨ |
|
Thanks a lot for the fix @haidargit 🙇🏻 Really appreciate your attention to detail in both the code (both scripts), PR title (convention commits), and PR description (screenshot) 👌🏻 👏🏻 |
|
@haidargit Today we prepared Release v3.2.0. Next week our QA team will review it and then we'll set it as the latest release for the install scripts & Your install script changes are already live for both the dev build and production build 🎉 You can try them out below: Latest Release Candidate (Dev Build): $ curl -fsSL https://downloads.slack-edge.com/slack-cli/install-dev.sh | bash -s slack-dev
$ slack-dev --version
Using slack-dev v3.2.0Latest Stable Release: $ curl -fsSL https://downloads.slack-edge.com/slack-cli/install.sh | bash
$ slack --version
Using slack v3.1.0Thanks again for the contribution 🙇🏻 At the bottom of Release v3.2.0 you're also listed as a first-time contributor 😄 |
Summary
Hi,
This PR improves the console output in the Deno installation part by adjusting the version check logic to handle string values (e.g., v2.3.1). Replaced numeric comparison with a neutral string check. Thanks.
Requirements