Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented May 14, 2025

Summary

This PR updates the tests for IsAPIHostSlackDev to confirm production and QA are not matched! Also updated are the formats to be table tests.

No change to functionalities but I am curious if QA should be considered dev 🤔

Requirements

@zimeg zimeg added this to the Next Release milestone May 14, 2025
@zimeg zimeg self-assigned this May 14, 2025
@zimeg zimeg requested a review from a team as a code owner May 14, 2025 05:02
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels May 14, 2025
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.17%. Comparing base (c326b5d) to head (756937d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   63.20%   63.17%   -0.04%     
==========================================
  Files         210      210              
  Lines       22194    22194              
==========================================
- Hits        14028    14021       -7     
- Misses       7082     7086       +4     
- Partials     1084     1087       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ So clean! 😭 Thanks for updating the test format and ensuring we don't match Slack Prod/QA 🙇🏻

@zimeg
Copy link
Member Author

zimeg commented May 15, 2025

@mwbrooks I'm so glad we're settling on these patterns across unit tests - it makes catching certain cases on scan somewhat easier IMO 🧪 ✨

@zimeg zimeg merged commit 29d536b into main May 15, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-test-apihost-dev branch May 15, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants