-
Notifications
You must be signed in to change notification settings - Fork 24
feat(bolt-install): set manifest source to remote for non-rosi projects #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 63.30% 63.31%
=======================================
Files 211 211
Lines 22276 22282 +6
=======================================
+ Hits 14101 14107 +6
Misses 7086 7086
Partials 1089 1089 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwbrooks Looks good to me! 🚢 💨
This is an exciting change for changes to follow and it's nice that this is behind the experiment for now!
| experiments: []string{"bolt", "bolt-install"}, | ||
| runtime: "node", | ||
| expectedOutputs: []string{ | ||
| `Updated config.json manifest source to "app settings" (remote)`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It's so nice to make this output explicit to avoid unexpected UI changes in perhaps later iteration 👾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I agree. I remember when you suggested adding it and it's helping to catch changes. 🪤
| The following is a list of currently available experiments. We may remove an experiment once the feature is released. | ||
|
|
||
| * `bolt-install`: enables creating, installing, and running Bolt projects that manage their app manifest on app settings (remote manifest). | ||
| * `slack create` and `slack init` now set manifest source to "app settings" (remote) for Bolt JS & Bolt Python projects ([PR#96](https://github.com/slackapi/slack-cli/pull/96)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔗 ✨
|
Thanks for the super quick review @zimeg and helping to document experiments better @technically-tracy 🙇🏻 Looks like we're safe to merge this one |
CHANGELOG
Summary
This pull request updates
slack create --experiment bolt-installandslack init --experiment bolt-installto set a different manifest source depending the runtime:manifest.source: "local"manifest.source: "remote"Previously, all runtimes used
manifest.source: "local".Reviewers
Requirements