Skip to content

refactor: enable linter rule QF1004 for 'Use strings.ReplaceAll when possible' #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwbrooks merged 2 commits into from
May 20, 2025
Merged

refactor: enable linter rule QF1004 for 'Use strings.ReplaceAll when possible' #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba3ca92
refactor: enable linter QF1004 'Use strings.ReplaceAll instead of str…
mwbrooks Apr 30, 2025
b967a87
Merge branch 'main' into mwbrooks-lint-qf1004
mwbrooks May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ linters:
- '-QF1001' # disable rule 'Apply De Morgan’s law'
- '-QF1012' # disable rule 'Use fmt.Fprintf instead of x.Write(fmt.Sprintf(...))'
- '-QF1003' # disable rule 'Convert if/else-if chain to tagged switch'
- '-QF1004' # disable rule 'Use strings.ReplaceAll instead of strings.Replace'
# https://golangci-lint.run/usage/linters/#staticcheck
# https://staticcheck.dev/docs/configuration/options/#initialisms
initialisms:
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ func InstallProjectDependencies(
// In the future, this function can be extended to support other Git hosts, such as GitLab.
// TODO, @cchensh, we should get prepared for other non-Git hosts and refactor the create pkg
func generateGitZipFileURL(templateURL string, gitBranch string) string {
zipURL := strings.Replace(templateURL, ".git", "", -1) + "/archive/refs/heads/"
zipURL := strings.ReplaceAll(templateURL, ".git", "") + "/archive/refs/heads/"
Copy link
Member

@zimeg zimeg May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zipURL := strings.ReplaceAll(templateURL, ".git", "") + "/archive/refs/heads/"
zipURL := strings.TrimSuffix(templateURL, ".git") + "/archive/refs/heads/"

🤔 This might've been an existing bug, but we might want to just trim the suffix here?

In this example the template URL for the project is changed in an unexpected fashion:

- https://github.com/slack-samples/example.git-project.git
+ https://github.com/slack-samples/example-project

I don't think we have a test that covers these cases, but it might be nice to cover this case with these changes 🙏 ✨

Copy link
Member Author

@mwbrooks mwbrooks May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a great find! I doubt we have a test for this, so I'm leaning toward merging this PR (linter enablement) and follow-up with a new PR that fixes this issue w/ tests (fix: creating projects from a template url that contains .git).


if gitBranch == "" {
mainURL := zipURL + "main.zip"
Expand Down
Loading