Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jul 2, 2025

Summary

This PR checks for typos or mispellings within a codebase to fix #99.

Notes

Requirements

@zimeg zimeg self-assigned this Jul 2, 2025
@zimeg zimeg added enhancement New feature or request semver:minor addressing/merging the change would necessitate a minor semver release github_actions Pull requests that update GitHub Actions code labels Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.66%. Comparing base (e383720) to head (be9558e).
⚠️ Report is 7 commits behind head on zimeg-feat-gha-checks.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           zimeg-feat-gha-checks     #105      +/-   ##
=========================================================
- Coverage                  94.77%   94.66%   -0.12%     
=========================================================
  Files                          6        6              
  Lines                        383      375       -8     
=========================================================
- Hits                         363      355       -8     
  Misses                        20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg
Copy link
Member Author

zimeg commented Jul 2, 2025

📣 https://github.com/slackapi/slack-health-score/actions/runs/16015365267/job/45180838432?pr=105#step:5:3221

Cool! This seems to work!

Warning: "commment" should be "comment".
error: `commment` should be `comment`
  --> ./test/helpers/helpers-test.js:108:13
    |
108 |             commmentType: null,
    |             ^^^^^^^^
    |
Error: Process completed with exit code 2.

@zimeg zimeg linked an issue Jul 2, 2025 that may be closed by this pull request
@zimeg
Copy link
Member Author

zimeg commented Jul 2, 2025

📝 To use a custom .typos.toml in a release we might have to switch to teunmooij/github-versioned-release 🐙

Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 A thought crossed mind about repo specific configs-

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 note: I'm concerned that using this file across multiple projects could block downstream changes if unexpected words appear that we should exclude.

thought: Changing this to be a nonblocking step or using a .typos.toml file from the project if found are perhaps ideas. I'm kind of wanting to start with this though...

@zimeg
Copy link
Member Author

zimeg commented Feb 10, 2026

📝 This should be non-blocking since we use a lot of magic words 🪄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request github_actions Pull requests that update GitHub Actions code semver:minor addressing/merging the change would necessitate a minor semver release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: error if mispellings are found to aviod typos

1 participant