Skip to content

Comments

refactor: inject dependencies to test action as a module#150

Open
zimeg wants to merge 2 commits intomainfrom
zimeg-test-esmock
Open

refactor: inject dependencies to test action as a module#150
zimeg wants to merge 2 commits intomainfrom
zimeg-test-esmock

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Feb 6, 2026

Summary

This PR follows #148 to inject dependencies into the inputs of this module for testing without esmock.

Requirements

@zimeg zimeg added this to the v0.1.2 milestone Feb 6, 2026
@zimeg zimeg requested a review from WilliamBergamin February 6, 2026 21:42
@zimeg zimeg self-assigned this Feb 6, 2026
@zimeg zimeg requested a review from a team as a code owner February 6, 2026 21:42
@zimeg zimeg added dependencies Pull requests that update a dependency file semver:patch addressing/merging the change would necessitate a patch semver release labels Feb 6, 2026
@zimeg
Copy link
Member Author

zimeg commented Feb 6, 2026

👾 @cjihrig Here we're extending mocks with a small adjacent refactor for testing without dependencies! ✨

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.52%. Comparing base (e469adc) to head (6e203b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   95.65%   97.52%   +1.87%     
==========================================
  Files          12       11       -1     
  Lines        1610     1332     -278     
==========================================
- Hits         1540     1299     -241     
+ Misses         70       33      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cjihrig
Copy link

cjihrig commented Feb 6, 2026

Ah, cool. Thanks for the ping 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file semver:patch addressing/merging the change would necessitate a patch semver release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants