Closed
Conversation
kx-chen
force-pushed
the
kx-chen/remove-dynamic-chunks-ff
branch
from
b7f6609 to
ef95f18
Compare
kx-chen
force-pushed
the
kx-chen/remove-dynamic-chunks-ff
branch
from
ef95f18 to
c1b5ffa
Compare
kyle-sammons
reviewed
Jan 8, 2026
Comment on lines
-111
to
-113
| cacheSlotMetadataStore = | ||
| new CacheSlotMetadataStore( | ||
| curatorFramework, etcdClient, metadataStoreConfig, meterRegistry); |
Collaborator
There was a problem hiding this comment.
Since this PR formalizes the transition from cache slots to cache assignments, can we get rid of the CacheSlotMetadataStore entirely?
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements