Draft
Conversation
ZacSweers
reviewed
Dec 21, 2025
build-logic/build.gradle.kts
Outdated
| @@ -0,0 +1,27 @@ | |||
| /* | |||
| * Copyright (C) 2022 Slack Technologies, LLC | |||
Collaborator
There was a problem hiding this comment.
nit: copyrights are wrong for a lot of these
tools/cli/build.gradle.kts
Outdated
| import org.jetbrains.kotlin.gradle.dsl.abi.ExperimentalAbiValidation | ||
|
|
||
| // KSP doesn't support isolated projects yet | ||
| // See: https://github.com/google/ksp/issues/XXXX (TODO: file upstream issue) |
Collaborator
There was a problem hiding this comment.
google/ksp#1943 I think is the one they're using
Fix copyright years (2022 -> 2026) on new files and replace KSP issue placeholder with actual link (google/ksp#1943). Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables Gradle's https://docs.gradle.org/current/userguide/isolated_projects.html feature (org.gradle.unsafe.isolated-projects=true), which allows Gradle to parallelize project configuration and improve configuration caching. So far I have the codebase building correctly with it, but I still need to do some testing to make sure I haven't created any breaking changes for consumers of the plugin.