Fixed race conditions for log writing and minor bugs in parser.go#58
Open
annab-stripe wants to merge 5 commits intoslackhq:masterfrom
Open
Fixed race conditions for log writing and minor bugs in parser.go#58annab-stripe wants to merge 5 commits intoslackhq:masterfrom
annab-stripe wants to merge 5 commits intoslackhq:masterfrom
Conversation
|
|
Collaborator
|
👋 @annab-stripe thanks for the PR. Can you do the CLA bit for us? |
Author
|
Hi, somebody from Stripe legal team signed one for me an year ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Added a mutex to AuditWriter in order to avoid a race condition.
Added a function
rotateto use the mutex to rotate logs.Modified tests accordingly to the previous changes and used an atomic.LoadUint32 for n.seq.
Added the
syscallJSON parameter in order for it to appear in AuditMessageGroup.Added 1305 to the
AddMessageswitch in order to not map the uid for that message.Related Issues
None
Test strategy
Modified the tests in order to work with the mutex changes. Tested in a test environment to verify the 'syscall' parameter was appearing in the JSON struct.