Skip to content

Add ability to skip applying rules#61

Open
davidhuie-dd wants to merge 1 commit intoslackhq:masterfrom
davidhuie-dd:david.huie/optional-rules
Open

Add ability to skip applying rules#61
davidhuie-dd wants to merge 1 commit intoslackhq:masterfrom
davidhuie-dd:david.huie/optional-rules

Conversation

@davidhuie-dd
Copy link
Copy Markdown

@davidhuie-dd davidhuie-dd commented Apr 2, 2019

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

This introduces a skip_rules configuration setting which prevents go-audit from setting rules itself. This enables audit rules to be set by an external system, utilizing go-audit exclusively for logging.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 2, 2019

Codecov Report

Merging #61 into master will decrease coverage by 0.1%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #61      +/-   ##
=========================================
- Coverage   75.21%   75.1%   -0.11%     
=========================================
  Files           5       5              
  Lines         476     478       +2     
=========================================
+ Hits          358     359       +1     
- Misses        101     102       +1     
  Partials       17      17
Impacted Files Coverage Δ
audit.go 74.68% <25%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf7385...ad94b32. Read the comment docs.

@davidhuie-dd
Copy link
Copy Markdown
Author

Is anyone checking these?

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 30, 2019

CLA assistant check
All committers have signed the CLA.

@nbrownus
Copy link
Copy Markdown
Collaborator

👋 @davidhuie-dd thanks for the PR! This looks like a good idea to me but I'd like to modify it a bit. rules.skip seems more natural, can you also update the example config with a little comment about the additional option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants