Add ability to skip applying rules#61
Open
davidhuie-dd wants to merge 1 commit intoslackhq:masterfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
- Coverage 75.21% 75.1% -0.11%
=========================================
Files 5 5
Lines 476 478 +2
=========================================
+ Hits 358 359 +1
- Misses 101 102 +1
Partials 17 17
Continue to review full report at Codecov.
|
Author
|
Is anyone checking these? |
Collaborator
|
👋 @davidhuie-dd thanks for the PR! This looks like a good idea to me but I'd like to modify it a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This introduces a
skip_rulesconfiguration setting which prevents go-audit from setting rules itself. This enables audit rules to be set by an external system, utilizing go-audit exclusively for logging.