Add native go line parser implementation to go-audit#62
Open
mwielgoszewski wants to merge 2 commits intoslackhq:masterfrom
Open
Add native go line parser implementation to go-audit#62mwielgoszewski wants to merge 2 commits intoslackhq:masterfrom
mwielgoszewski wants to merge 2 commits intoslackhq:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
- Coverage 75.21% 46.9% -28.31%
==========================================
Files 5 6 +1
Lines 476 776 +300
==========================================
+ Hits 358 364 +6
- Misses 101 393 +292
- Partials 17 19 +2
Continue to review full report at Codecov.
|
glaslos
reviewed
Jul 25, 2019
| AUDIT_FANOTIFY: "fanotify", | ||
| } | ||
|
|
||
| var syscallNumbers = map[uint16]string{ |
There was a problem hiding this comment.
FYI this mapping is kernel and architecture specific.
Author
|
@wadey what would it take to get this merged? |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
===========================================
- Coverage 75.21% 46.90% -28.31%
===========================================
Files 5 6 +1
Lines 476 776 +300
===========================================
+ Hits 358 364 +6
- Misses 101 393 +292
- Partials 17 19 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR implements a native lineparser (javascript implementation originally written by @nbrownus) directly into go-audit.
For performance reasons, it is turned off by default, but may be switched on via two configuration options under
message_decoding:enabledsimply performs basic line parsing.human_friendly_messagesextends this parsing to construct human-friendly messages based on the contents of an audit message.