vtadmin /schemas sort results by distance (exact matches up top)#800
Open
neil-harkins-sf wants to merge 229 commits intomainfrom
Open
vtadmin /schemas sort results by distance (exact matches up top)#800neil-harkins-sf wants to merge 229 commits intomainfrom
neil-harkins-sf wants to merge 229 commits intomainfrom
Conversation
…io#15141) (vitessio#15147) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…) (vitessio#15155) Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…#15144) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…sio#15143) Signed-off-by: Andres Taylor <andres@planetscale.com>
…ssio#15148) (vitessio#15150) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Andrew Mason <amason@hey.com>
…ease (vitessio#15165) Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Vicent Marti <vmg@strn.cat>
…#15180) (vitessio#15181) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Vicent Marti <vmg@strn.cat> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…og daemon disabled (vitessio#15176) (vitessio#15186) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…vitessio#15196) Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
) (vitessio#15206) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Vicent Marti <vmg@strn.cat>
…tessio#15197) (vitessio#15209) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…tessio#15210) (vitessio#15213) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…itessio#15235) (vitessio#15239) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…nalysis in two (vitessio#15217) (vitessio#15230) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com>
…itessio#15246) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
… cleanup (vitessio#15261) (vitessio#15265) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
…15264) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…sio#15259) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
…itessio#15218) (vitessio#15255) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
…ssio#15275) (vitessio#15282) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…itessio#15279) (vitessio#15285) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…/Precision (vitessio#15256) (vitessio#15269) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…o#15251) (vitessio#15286) Signed-off-by: Matt Layher <mdlayher@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
vitessio#15204) (vitessio#15292) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
… (vitessio#15301) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
This reverts commit 5595d65.
…ng for connection (#712) * CONNPOOL: Fix race condition when waiting for connection (vitessio#18712) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * connpool: Bump the hang detection timeout to 1 second. (vitessio#18722) Signed-off-by: Arthur Schreiber <arthur@planetscale.com> * connpool: Don't use go internal `sema` functionality (vitessio#18719) Signed-off-by: Arthur Schreiber <arthur@planetscale.com> --------- Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
* Update mysql-apt-config to version 0.8.35-1 Updated mysql-apt-config package from version 0.8.33-1 to 0.8.35-1 across all CI workflow templates and files to use the latest available version. Changes: - Updated template files (cluster_endtoend_test.tpl, cluster_endtoend_test_mysql57.tpl, cluster_vitess_tester.tpl, unit_test.tpl) - Fixed template syntax error in cluster_vitess_tester.tpl (GH_ACCESS_TOKEN) - Regenerated all workflow files from updated templates 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Remove MySQL uninstall comment from CI workflows Removed the comment "# Uninstall any previously installed MySQL first" from template files and individual workflow files. This comment was no longer relevant since the actual MySQL uninstall commands were previously removed. Changes: - Removed comment from template files (unit_test.tpl, cluster_endtoend_test_mysql57.tpl) - Removed comment from individual workflow files (upgrade_downgrade_test_*, unit_test_mysql80.yml, codeql_analysis.yml) - Regenerated workflow files from updated templates This completes the cleanup of MySQL uninstall-related content from CI workflows. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Remove MySQL uninstall sections from upgrade_downgrade test workflows Removed MySQL uninstall commands from all upgrade_downgrade test workflow files. These commands included systemctl stop apparmor, apt-get remove, autoremove, autoclean, deluser mysql, and rm -rf commands that could cause issues in CI environments. Changes: - Removed uninstall sections from 10 upgrade_downgrade workflow files - Preserved all MySQL installation and configuration commands - Workflows now proceed directly to MySQL installation without cleanup Files modified: - upgrade_downgrade_test_backups_manual.yml - upgrade_downgrade_test_backups_manual_next_release.yml - upgrade_downgrade_test_query_serving_*.yml (4 files) - upgrade_downgrade_test_reparent_*.yml (4 files) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Fix unit_test_mysql80.yml and template - remove uninstall steps and update version Fixed issues in unit_test_mysql80.yml and unit_test.tpl template: 1. Removed MySQL uninstall section from template that was causing issues 2. Updated mysql-apt-config version from 0.8.29-1 to 0.8.35-1 in template 3. Regenerated workflow files from corrected template Changes: - Fixed unit_test.tpl template to remove MySQL uninstall commands - Updated mysql-apt-config version to 0.8.35-1 in template - Regenerated unit_test_mysql80.yml and other workflow files from clean template 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * undo some changes Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix typo Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * undo some changes Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix conflicts Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
* fix: consolidator waiter cap fallback to independent execution When the consolidator waiter cap is reached, queries should fall back to independent execution instead of returning empty results. Before this fix: - Queries exceeding waiter cap would skip waiting for consolidation - They would immediately try to access q.Result() before completion - This resulted in empty/incomplete results being returned After this fix: - Queries exceeding waiter cap fall back to regular execution path - All queries return correct results regardless of consolidation status - Waiter cap configuration still controls resource usage as intended Changes: - Modified execSelect() in query_executor.go to implement fallback logic - Enhanced FakePendingResult to properly simulate waiter count behavior - Added comprehensive test TestQueryExecutorConsolidatorWaiterCapFallback Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * implement consolidator-query-waiter-cap-method * fix help message Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix redundant code * fix test Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * feat: add consolidator-query-waiter-cap-method config parameter Add --consolidator-query-waiter-cap-method flag to control behavior when consolidator waiter cap is exceeded. Options: - 'fallthrough' (default): Fall back to independent query execution - 'reject': Return RESOURCE_EXHAUSTED error This provides operators fine-grained control over consolidator memory management while maintaining backward compatibility. Changes: - Add ConsolidatorQueryWaiterCapMethod config field and CLI flag - Update execSelect() to handle both reject and fallthrough behaviors - Add comprehensive test coverage for both methods - Add config validation with graceful defaults - Fix waiter counter cleanup to ensure proper resource management Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> --------- Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
…ery Execution and Update Query Timeout / Cancelled Error Message (#725) * Use Kill Query for Non-Transaction Query Execution and Update Query Timeout / Cancelled Error Message (vitessio#15694) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * remove v20 change log Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
…ation (#732) * fix: restore tablet type from topo on restart instead of using init_tablet_type When a vttablet process restarts, it should restore its tablet type from the topology service rather than using the --init_tablet_type flag value. This ensures that tablets maintain their assigned roles across restarts. Previously, on restart, the tablet type would incorrectly be set to the value specified in --init_tablet_type, which could cause disruption in the cluster if a tablet had been promoted to PRIMARY or changed to a different type after initial startup. This fix: 1. Reads the tablet record from topology during startup 2. If an existing record is found, uses its tablet type instead of --init_tablet_type 3. Preserves the PRIMARY term start time if tablet was previously a PRIMARY 4. Updates the flag documentation to clarify that it's only used during initial creation Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * gates tablet type lookup behind a flag * updating branch with changes proposed to upstream Signed-off-by: Stephen Baker <s.baker@slack-corp.com> * updates template for expected vttablet --help to reflect new/changed flags Signed-off-by: Stephen Baker <s.baker@slack-corp.com> * include updated flags for vtcombo.txt Signed-off-by: Stephen Baker <s.baker@slack-corp.com> * porting in changes to align with upstream PR Signed-off-by: Stephen Baker <s.baker@slack-corp.com> * more underscore & hyphen shenanigans Signed-off-by: Stephen Baker <s.baker@slack-corp.com> * updating expected output for tests Signed-off-by: Stephen Baker <s.baker@slack-corp.com> --------- Signed-off-by: Stephen Baker <s.baker@slack-corp.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
* Fix GC table regex for lower case compatibility * gofmt
…se cases (vitessio#18938) (#755) Signed-off-by: twthorn <thomaswilliamthornton@gmail.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
…onnection reopen (vitessio#18967) (#759) * connpool: fix connection leak during idle connection reopen (vitessio#18967) Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * change require to assert Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix test Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
…logic (19004) (#763) * Change how we expire idle connections. Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Add a test. Signed-off-by: Arthur Schreiber <arthur@planetscale.com> * Loosen up test requirements. Signed-off-by: Arthur Schreiber <arthur@planetscale.com> * Expire only up to 50% of the connections, and add some comments. Signed-off-by: Arthur Schreiber <arthur@planetscale.com> * Also pre-allocate the valid connections slice. Signed-off-by: Arthur Schreiber <arthur@planetscale.com> * Skip slice allocations for empty stacks. Signed-off-by: Arthur Schreiber <arthur@planetscale.com> * Fix benchmark setup. Signed-off-by: Arthur Schreiber <arthur@planetscale.com> * fix b.Loop Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Arthur Schreiber <arthur@planetscale.com>
* Improve logging in buffering (vitessio#17294) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Improve vtgate logging for buffering (vitessio#17654) Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Signed-off-by: deepthi <deepthi@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com>
#764) * VStream: Prevent buffering entire transactions (OOM risk), instead send chunks to client (vitessio#18849) Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> * Fix static code checks Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> * Remove utils import Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> * Fix keyspaces to watch test Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> --------- Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
…ons (#768) * [release-19.0] Implement temporal comparisons (vitessio#17826) (vitessio#17852) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * [release-19.0] Fix week number for date_format evalengine function (vitessio#17432) (vitessio#17454) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
…LOB for VReplication (vitessio#19119) (#770) This backport increases the GTID position column size from BLOB to LONGBLOB in VReplication tables to prevent data truncation for large GTID sets. Backported from vitessio#19119 Original commit: fc242ff Changes: - Update schema_version.sql to use LONGBLOB for pos column - Update vreplication.sql to use LONGBLOB for pos column - Update schema tests to reflect new column type Note: Test file changes from upstream were not included as they depend on features not present in slack-19.0 branch. Core schema changes are sufficient.
Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
…also send Serve… (#775) * [Direct PR] [release-21.0] Augment `PrimaryStatus` to also send Server UUID (vitessio#17032) Signed-off-by: Manan Gupta <manan@planetscale.com> * test: disable two failing VTOrc primary failure tests Disable flaky tests: - TestDownPrimaryPromotionRuleWithLag - TestDownPrimaryPromotionRuleWithLagCrossCenter Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * test: fix redo log verification timeout in backup test Add two safeguards to prevent TestTabletInitialBackup from timing out: 1. Check if performance_schema.error_log table exists and is accessible before querying it for redo log error codes 2. Add a 10-second timeout for the verification loop to prevent indefinite waiting if the error codes never appear in the error_log The performance_schema.error_log table requires MySQL 8.0.22+ and specific configuration. Even when the table exists, it may not be configured to log the redo log disable/enable events (MY-013600, MY-013601). If the verification times out, it now logs a message and skips gracefully instead of failing the entire test. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> * test: fix race condition in TestServerStats Use assert.EventuallyWithT to wait for connection cleanup instead of checking connCount and connSlow immediately after client disconnect. The server's cleanup goroutine needs time to execute defer statements that update these metrics. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
* Set last release to release-18.0 to pass downgrade/upgrade tests * Set previous build to v19 train 1 * set last release to v19.0.7-slack-t3.6 * set last release to v19.0.7-slack-t3.6
* Fix: transition to `math/rand/v2` for Improved Performance and Code Clarity (vitessio#15438) Signed-off-by: Aoang <aoang@x2oe.com> Signed-off-by: Eduardo Ortega <5791035+ejortegau@users.noreply.github.com> * Linkname removal (step 1) (vitessio#16016) Signed-off-by: Vicent Marti <vmg@strn.cat> --------- Signed-off-by: Aoang <aoang@x2oe.com> Signed-off-by: Eduardo Ortega <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Aoang <aoang@x2oe.com> Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com>
…dle more cases. (vitessio#16926) (#779) * Improve errant GTID detection in ERS to handle more cases. (vitessio#16926) Signed-off-by: Manan Gupta <manan@planetscale.com> * disable upgrade_downgrade_test_reparent_old_vttablet.yml * skip TestAliasesInOuterJoinQueries --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
vitessio#18132) (#780) * [release-19.0] DML test fix for duplicate column value (vitessio#18132) * fix: enable Percona tools repository before ps80 setup Percona repository structure now requires the tools repository to be enabled before setting up ps80. This fixes the CI error: "Selected product uses 'ps-80 tools' repositories. But the 'tools' repository is disabled" Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> --------- Co-authored-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
|
Thanks for the contribution! Before we can merge this, we need @systay @frouioui to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what
/schemas?filter=userslooks like today:i.e. there is a table named exactly
users, which is what i'm looking for (to see columns), but it appears on page 2 (51 - 100 of 130 results). The change in this PR will put exact matches at the top.