Remove Unused and Deprecated Classes #1110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@slacrherbst I am concerned about the
@ddoering Ping you as a lot of these applications are in your scope |
Contributor
|
@slacrherbst I agree with Larry about the impact on the detector projects. This would break them since software triggers are based on the srp.cmd(). If we go ahead with this deprecation, what will be the changes that the projects will have to do? Is there guideline for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the deprecated legacy file writer and reader
LegacyFileWriter and LegacyFileReader
Also removed the non supported CMD interface to SRP
protocols/srp/Cmd