Implement Docker #20
Open
Implement Docker #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ciboulette
reviewed
Dec 21, 2019
Ciboulette
left a comment
Ciboulette
left a comment
There was a problem hiding this comment.
I think it comes from a good idea! But I think it's not perfect yet, you should have a look to my comments 💯
| password: "postgres", | ||
| database: "conduit_eventstore_dev", | ||
| hostname: "localhost", | ||
| hostname: "eventstore", |
There was a problem hiding this comment.
By doing this, you will force everybody to run on docker. Because if you run it locally it won't work..
I'm pretty sure this is not what people want :) What do you think?
| password: "postgres", | ||
| database: "conduit_readstore_dev", | ||
| hostname: "localhost", | ||
| hostname: "readstore", |
| - 4000:4000 | ||
|
|
||
| eventstore: | ||
| image: postgres |
There was a problem hiding this comment.
I think you should prefix and use a fix major version.
| image: postgres | ||
|
|
||
| readstore: | ||
| image: postgres |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easier to get up and running.