Raspiaudio Muse Luxe 2025/11/26

[RASPIAUDIOadmin]

The modifications concern the Muse Luxe from RaspiAudio.

This involves enabling the headphone jack for use with headphones.

Two files are slightly modified:

• Kconfig.projbuild
  To correct the jack's GPIO pin number.

To enable and amplify output 2 during ES8388 initialization.

• monitor.c
  To enable the jack's GPIO pull-up resistor to ensure proper recognition when the jack is removed.

[gemini-code-assist]

Summary of Changes

Hello @RASPIAUDIOadmin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the audio capabilities of the RaspiAudio Muse Luxe by fully enabling and optimizing its headphone jack. It addresses both hardware configuration (correcting GPIOs and enabling pull-ups) and audio codec initialization (amplifying output 2) to provide a robust and functional headphone experience.

Highlights

• Headphone Jack Activation: The pull request enables the headphone jack functionality for the RaspiAudio Muse Luxe device.
• GPIO Pin Correction: The correct GPIO pin number for the headphone jack is now configured.
• Audio Output Amplification: Output 2 of the ES8388 audio codec is enabled and amplified during initialization.
• Jack Detection Reliability: A GPIO pull-up resistor is enabled for the jack detection pin to ensure reliable recognition when headphones are inserted or removed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces modifications for the RaspiAudio Muse Luxe to enable the headphone jack. The changes include correcting the jack's GPIO pin, enabling the internal pull-up resistor for jack detection, and updating the DAC initialization sequence. The changes are logical and well-contained. I've added one suggestion to improve the readability of the Kconfig file, which will help with future maintenance.

[gemini-code-assist]

This long line of configuration is difficult to read and maintain. For better readability and to make future changes easier to review, please consider reformatting it to span multiple lines using line continuations. I've also noticed and fixed some inconsistent spacing (extra space before a comma, and tabs) in the suggested change.

Using a multi-line format for long strings is a common practice in Kconfig files and greatly improves code clarity.

			default "{\"init\":[{\"reg\":0,\"val\":128}, {\"reg\":0,\"val\":0}, {\"reg\":25,\"val\":4}, {\"reg\":1,\"val\":80}, {\"reg\":2,\"val\":0}, " \
			        "{\"reg\":8,\"val\":0}, {\"reg\":4,\"val\":192}, {\"reg\":0,\"val\":18}, {\"reg\":1,\"val\":0}, {\"reg\":23,\"val\":24}, " \
			        "{\"reg\":24,\"val\":2}, {\"reg\":38,\"val\":9}, {\"reg\":39,\"val\":144}, {\"reg\":42,\"val\":144}, {\"reg\":43,\"val\":128}, " \
			        "{\"reg\":45,\"val\":128}, {\"reg\":27,\"val\":0}, {\"reg\":26,\"val\":0}, {\"reg\":2,\"val\":240}, {\"reg\":2,\"val\":0}, " \
			        "{\"reg\":29,\"val\":28}, {\"reg\":4,\"val\":60}, {\"reg\":25,\"val\":0}, {\"reg\":46,\"val\":33}, {\"reg\":47,\"val\":33}, " \
			        "{\"reg\":48,\"val\":33}, {\"reg\":49,\"val\":33}]}" if MUSE