Fix C++17 compatibility for GCC 14 / Rocky Linux 10 (RHEL 10)#60
Open
773-process-312 wants to merge 1 commit intosleuthkit:masterfrom
Open
Fix C++17 compatibility for GCC 14 / Rocky Linux 10 (RHEL 10)#60773-process-312 wants to merge 1 commit intosleuthkit:masterfrom
773-process-312 wants to merge 1 commit intosleuthkit:masterfrom
Conversation
- Fix scalpelInputIsOpen return type: const char -> unsigned char (matches the unsigned char isOpen field in ScalpelInputReader struct) - Remove dynamic exception specifications throw() from scalpel.h and scalpel.cpp (removed in C++17, rejected by GCC 14) Tested on: Rocky Linux 10.1 (Red Quartz), GCC 14.3.1 (Red Hat 14.3.1-2) Requires: libtre 0.8.0 built from source (unavailable as el10 package) Reference build and install scripts: https://github.com/773-process-312/scalpel-rocky10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Proposed
Scalpel 2.1 fails to compile on Rocky Linux 10 (RHEL 10 / el10)
with GCC 14.3.1 due to C++17 incompatibilities:
const charreturn type onscalpelInputIsOpenconflicts withthe
unsigned char isOpenfield in the ScalpelInputReader structthrow()are removed in C++17and rejected as hard errors by GCC 14
Fix
scalpelInputIsOpenreturn type tounsigned charin bothinput_reader.h and input_reader.cpp to correctly match the struct field
throw()exception specifications from scalpel.h and scalpel.cppTested On
Notes
libtre is also unavailable as a package on RHEL 10 / Rocky Linux 10
and must be built from source. A full documented build guide including
pre-built binaries and patch scripts is available at:
https://github.com/773-process-312/scalpel-rocky10 Sonnet 4.6