UselessParenthesesSniff: Fixed false positive

pepakriz · kukulich · commit 3cb058711ddd · 2019-12-13T08:23:38.000+01:00
diff --git a/SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php b/SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php
@@ -461,6 +461,10 @@ private function checkParenthesesAroundOperators(File $phpcsFile, int $parenthes
 			if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_DIVIDE && in_array($tokens[$firstOperatorPointer]['code'], [T_DIVIDE, T_MULTIPLY], true)) {
 				return;
 			}
+
+			if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_MODULUS && $tokens[$firstOperatorPointer]['code'] === T_MODULUS) {
+				return;
+			}
 		}
 
 		$lastOperatorPointer = $operatorsPointers[count($operatorsPointers) - 1];
diff --git a/tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php b/tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php
@@ -133,6 +133,8 @@ function () {
 
 $a = 10 - (5 - 2);
 
+$a = 6 % (5 % 3);
+
 pow(10, -($x + 1));
 
 if (! ($i === $j - 1)) {

Original file line number	Diff line number	Diff line change
`@@ -461,6 +461,10 @@ private function checkParenthesesAroundOperators(File $phpcsFile, int $parenthes`
`461`	`461`	`if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_DIVIDE && in_array($tokens[$firstOperatorPointer]['code'], [T_DIVIDE, T_MULTIPLY], true)) {`
`462`	`462`	`return;`
`463`	`463`	`}`
	`464`	`+`
	`465`	`+ if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_MODULUS && $tokens[$firstOperatorPointer]['code'] === T_MODULUS) {`
	`466`	`+ return;`
	`467`	`+ }`
`464`	`468`	`}`
`465`	`469`
`466`	`470`	`$lastOperatorPointer = $operatorsPointers[count($operatorsPointers) - 1];`