ModernClassNameReferenceSniff: Fixed false positives with get_class()

Author: kukulich

SlevomatCodingStandard/Sniffs/Classes/ModernClassNameReferenceSniff.php

@@ -89,8 +89,13 @@ private function checkFunctionCall(File $phpcsFile, int $pointer): void
 		}
 
 		if ($functionName === 'get_class') {
-			$parameterPointer = TokenHelper::findNext($phpcsFile, T_VARIABLE, $openParenthesisPointer + 1, $tokens[$openParenthesisPointer]['parenthesis_closer']);
-			if ($parameterPointer !== null) {
+			$parameterPointer = TokenHelper::findNextEffective($phpcsFile, $openParenthesisPointer + 1, $tokens[$openParenthesisPointer]['parenthesis_closer']);
+
+			if ($parameterPointer === null) {
+				$fixedContent = 'self::class';
+			} elseif ($tokens[$parameterPointer]['code'] !== T_VARIABLE) {
+				return;
+			} else {
 				$parameterName = strtolower($tokens[$parameterPointer]['content']);
 				if ($parameterName !== '$this') {
 					return;
@@ -102,8 +107,6 @@ private function checkFunctionCall(File $phpcsFile, int $pointer): void
 				}
 
 				$fixedContent = 'static::class';
-			} else {
-				$fixedContent = 'self::class';
 			}
 
 		} elseif ($functionName === 'get_parent_class') {

tests/Sniffs/Classes/data/modernClassNameReferenceNoErrors.php

@@ -27,4 +27,10 @@ public function getClassWithMoreThanThisParameter()
 	{
 		return get_class($this->anything);
 	}
+
+	public function getClassWithSomethingElse()
+	{
+		return get_class(new stdClass());
+	}
+
 }