UselessParenthesesSniff: Fixed false positive

Author: pepakriz

SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php

@@ -461,6 +461,10 @@ private function checkParenthesesAroundOperators(File $phpcsFile, int $parenthes
 			if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_DIVIDE && $tokens[$firstOperatorPointer]['code'] === T_DIVIDE) {
 				return;
 			}
+
+			if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_DIVIDE && $tokens[$firstOperatorPointer]['code'] === T_MULTIPLY) {
+				return;
+			}
 		}
 
 		$lastOperatorPointer = $operatorsPointers[count($operatorsPointers) - 1];

tests/Sniffs/PHP/UselessParenthesesSniffTest.php

@@ -17,9 +17,9 @@ public function testErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/uselessParenthesesErrors.php');
 
-		self::assertSame(40, $report->getErrorCount());
+		self::assertSame(41, $report->getErrorCount());
 
-		foreach ([8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 36, 37, 38, 41, 42, 43, 44, 49, 53, 55, 56, 57, 58, 63] as $line) {
+		foreach ([8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 36, 37, 38, 41, 42, 43, 44, 49, 53, 55, 56, 57, 58, 64] as $line) {
 			self::assertSniffError($report, $line, UselessParenthesesSniff::CODE_USELESS_PARENTHESES);
 		}
 

tests/Sniffs/PHP/data/uselessParenthesesErrors.fixed.php

@@ -57,6 +57,7 @@ function () {
 $x = 100 / 50 * 100;
 $x = $a + $b * 3;
 $x = $b + 100 - $c;
+$x = $b * 100 / $c;
 
 function () {
 	return [

tests/Sniffs/PHP/data/uselessParenthesesErrors.php

@@ -57,6 +57,7 @@ function () {
 $x = ((100 / 50) * 100);
 $x = ($a + $b * 3);
 $x = $b + (100 - $c);
+$x = $b * (100 / $c);
 
 function () {
 	return [

tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php

@@ -129,6 +129,8 @@ function () {
 
 $a = 10 / (5 / 2);
 
+$a = 10 / (5 * 2);
+
 pow(10, -($x + 1));
 
 if (! ($i === $j - 1)) {