autostart: add support for flatpak, add buttons to manually request/disable#838
Draft
deltragon wants to merge 10 commits intoslgobinath:masterfrom
Draft
autostart: add support for flatpak, add buttons to manually request/disable#838deltragon wants to merge 10 commits intoslgobinath:masterfrom
deltragon wants to merge 10 commits intoslgobinath:masterfrom
Conversation
also merge duplicated code in initialize and reset
Also skip saving the file on load if it is unchanged. (It will only changed when new default values are added on an update). The timing when the config is loaded is moved around, as otherwise logging may not be initialized yet.
Only load the config in the main GTK instance, and not the CLI instances. This can be changed again later, but it is not needed right now, so we skip it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on #837 and #836, only the last five commits are new.
This PR adds support for flatpak for autostarting Safe Eyes on boot.
It also adds buttons to the settings to request/disable autostart, both for flatpak and non-flatpak.
Note that the behaviour between flatpak and non-flatpak isn't entirely the same - since it isn't possible to detect whether there is an autostart file in flatpak, we only request it on the first startup (and whenever the user manually triggers it from the settings), and can't check if it's broken or repair it.