Closed
Conversation
Member
|
Net::SSL needs to be added as a dependency in Build.PL and this means we need to include openssl in the builds. Since we're in the process of reworking our builds, let's not add one more dependency for now. |
Author
|
Ahh I see okay, well any Idea how to get around Net::SSL? I will try a few things the next days and report back when I found a solution. |
Member
|
We're going C++ soon. We can use boost::asio with OpenSSL, but we need to make this dependency optional (i.e. allow people to compile without SSL support). |
Member
|
Incorporated into #4795 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix #3203.
For me it was necessary to disable the hostname check, no matter what I did perl was not able to verify the hostname, not even if I specify the path to the certificates... maybe someone can take a look at this part.
Next was to remove the hard coded http:// and replace it with a regex check, so basically I check if the url starts with http if not http:// will be appended.
But now you can add a https:// in front of the url so that it now gets recognized as a secure connection.