-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: add pause-by-duration control for SlidevVideo #2236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for slidev failed.
|
Hi, I've added support for segmented video playback with the pause=[1,2,3,'end'] format. |
README.md
Outdated
### Init Project Locally | ||
|
||
Install [Node.js >=18](https://nodejs.org/) and run the following command: | ||
# 🎬 SlidevVideo Playback Demo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this file has been changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Anthony, thanks for the feedback!
I thought I was only editing my fork, so I put the demo into the README for quick testing.
Now I understand it should go into the docs and in English.
I’ll move the content into the docs and update the PR. Thanks for pointing it out!
dev.md
Outdated
# 🎬 SlidevVideo Demo | ||
|
||
> A demo for multi-step controlled playback using `pause=[1, 2, 3, 'end']` | ||
> 使用 `pause=[1, 2, 3, 'end']` 控制多段播放的展示 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the docs instead? And use English, please. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I’ll move the demo into the docs in English and update the PR soon.
Hi, I’ve updated the PR — reverted the README changes and added a new English docs page for the video playback demo. |
This PR adds support for
pause=[1,2,3,'end']
format in SlidevVideo component.The video now plays segment-by-segment with user click between segments.
Supports fractional seconds like
[3.5, 2.5, 3]
Ends with autoplay or manually controlled 'end' keyword.
Fixes #2177 - Clickable Video