Fix conversion of multi-line method arguments #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regexps responsible for converting method calls with blocks did not account for arguments split across multiple lines. This patch enables multi-line method arguments, as long as every line except the last ends with a comma (and zero or more spaces).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regexps responsible for converting method calls with blocks did not account for arguments split across multiple lines. This patch enables multi-line method arguments, as long as every line except the last ends with a comma (and zero or more spaces).
Fixes #40
This patch is intentionally limited in scope. It does not handle lines which end with, e.g.
&&. If someone wants to compile a set of use cases, I can make a follow-up PR which tries to accommodate them.