Skip to content

Conversation

@arshidkv12
Copy link

Remove setAccessible() calls to support PHP 8.5 and avoid deprecation

@coveralls
Copy link

Coverage Status

coverage: 99.523%. remained the same
when pulling 53c1ac6 on arshidkv12:4.x
into 5cb7734 on slimphp:4.x.

@odan
Copy link
Contributor

odan commented Aug 22, 2025

There is a lot of redundant code. Could you move this into a method?

@arshidkv12
Copy link
Author

ok.

@akrabat
Copy link
Member

akrabat commented Oct 30, 2025

If we drop support for anything less than PHP 8.1, we could just delete the calls to setAccessible(). Unfortunately, 8.1 was only release 4 years ago, which might be a little too recent. What do you think @odan ?

@odan
Copy link
Contributor

odan commented Nov 1, 2025

@akrabat I think keeping PHP 8.1 adds extra maintenance overhead (CI jobs, tests, etc.).

I would suggest aligning with PHP’s official security timeline and keeping 8.1 support only until 31 Dec 2025 (supported versions).
That’s just one month away, so we could already prepare to drop it in the next release.

@odan
Copy link
Contributor

odan commented Nov 9, 2025

Thanks for the PR. We are working on the changes for PHP 8.5 in this PR: #3415
Closing this as duplicate.

@odan odan closed this Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants