-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Allow PHPUnit 10, 11 and 12 #3411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Changes look good. Need to sort out the config though. |
Thanks, it's a bit unexpected |
|
@akrabat I improved the GitHub actions workflow, all does pass on my fork That said there is something wrong in the code somewhere. Edit: For example on the merge: https://github.com/slimphp/Slim/actions/runs/17945163370/job/51029735524 PS: bonus, I fixed gitattributes for new added dev stuff |
That's really weird as the composer step shows that the Nyholm PSR7 implementation had been installed. |
|
Yes and locally when you re run phpunit it may go green |
No backwards incompatible changes