Skip to content

Conversation

@williamdes
Copy link
Contributor

No backwards incompatible changes

@akrabat
Copy link
Member

akrabat commented Sep 20, 2025

Changes look good. Need to sort out the config though.

@williamdes
Copy link
Contributor Author

Changes look good. Need to sort out the config though.

Thanks, it's a bit unexpected
I will process it today

@williamdes
Copy link
Contributor Author

williamdes commented Sep 20, 2025

@akrabat I improved the GitHub actions workflow, all does pass on my fork

That said there is something wrong in the code somewhere.
One out of x times this test fails


1) Slim\Tests\Factory\AppFactoryTest::testCreateAppWithEmptyContainer
RuntimeException: Could not detect any PSR-17 ResponseFactory implementations. Please install a supported implementation in order to use `AppFactory::create()`. See https://github.com/slimphp/Slim/blob/4.x/README.md for a list of supported implementations.

/home/runner/work/Slim/Slim/Slim/Factory/AppFactory.php:152
/home/runner/work/Slim/Slim/Slim/Factory/AppFactory.php:84
/home/runner/work/Slim/Slim/tests/Factory/AppFactoryTest.php:397

Edit: For example on the merge: https://github.com/slimphp/Slim/actions/runs/17945163370/job/51029735524

PS: bonus, I fixed gitattributes for new added dev stuff

@coveralls
Copy link

Coverage Status

coverage: 99.608% (+0.09%) from 99.523%
when pulling d2a9975 on williamdes:phpunit-upgrades
into 17eba51 on slimphp:4.x.

@akrabat akrabat merged commit 18d0fe0 into slimphp:4.x Sep 23, 2025
9 checks passed
@williamdes williamdes deleted the phpunit-upgrades branch September 23, 2025 11:48
@akrabat
Copy link
Member

akrabat commented Sep 23, 2025

That said there is something wrong in the code somewhere. One out of x times this test fails


1) Slim\Tests\Factory\AppFactoryTest::testCreateAppWithEmptyContainer
RuntimeException: Could not detect any PSR-17 ResponseFactory implementations. Please install a supported implementation in order to use `AppFactory::create()`. See https://github.com/slimphp/Slim/blob/4.x/README.md for a list of supported implementations.

/home/runner/work/Slim/Slim/Slim/Factory/AppFactory.php:152
/home/runner/work/Slim/Slim/Slim/Factory/AppFactory.php:84
/home/runner/work/Slim/Slim/tests/Factory/AppFactoryTest.php:397

Edit: For example on the merge: https://github.com/slimphp/Slim/actions/runs/17945163370/job/51029735524

That's really weird as the composer step shows that the Nyholm PSR7 implementation had been installed.

@williamdes
Copy link
Contributor Author

Yes and locally when you re run phpunit it may go green

@akrabat akrabat added this to the 4.15.1 milestone Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants