Skip to content

Fix SharedVectorHeader alignment mismatch on ARM32 platforms #10098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Fix SharedVectorHeader alignment mismatch on ARM32 platforms #10098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/cpp/include/slint_sharedvector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ struct SharedVector

#if !defined(DOXYGEN)
// Unfortunately, this cannot be generated by cbindgen because std::atomic is not understood
struct SharedVectorHeader
struct alignas(8) SharedVectorHeader
{
std::atomic<std::intptr_t> refcount;
std::size_t size;
Expand Down
2 changes: 1 addition & 1 deletion internal/core/sharedvector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use core::ptr::NonNull;

use portable_atomic as atomic;

#[repr(C)]
#[repr(C, align(8))]
struct SharedVectorHeader {
refcount: atomic::AtomicIsize,
size: usize,
Expand Down
Loading