-
Notifications
You must be signed in to change notification settings - Fork 780
Add StyledText type #10122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+590
−5
Merged
Add StyledText type #10122
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b6d9215
Add StyledText type
expenses 1bf27cd
Move to styled-text.rs
expenses 1d52442
Apply suggestions
expenses 0ca15e2
Don't gate around experimental-rich-text feature
expenses 235cc25
Gate pulldown_cmark behind std
expenses 729b16a
[autofix.ci] apply automated fixes
autofix-ci[bot] 8093aa7
Make thiserror optional
expenses 53ca579
Make htmlparser optional
expenses 2f696da
Gate color-parsing feature
expenses a624471
[autofix.ci] apply automated fixes
autofix-ci[bot] b10cacc
Change flags
expenses 374b6d9
Change to pub(crate)
expenses 7cbfe8c
[autofix.ci] apply automated fixes
autofix-ci[bot] e4c37e2
Better docs
expenses File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,9 @@ use crate::window::{WindowAdapter, WindowInner}; | |
| use alloc::boxed::Box; | ||
| use alloc::string::String; | ||
|
|
||
| mod styled_text; | ||
| pub use styled_text::*; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The whole module can be gated on |
||
|
|
||
| /// A position represented in the coordinate space of logical pixels. That is the space before applying | ||
| /// a display device specific scale factor. | ||
| #[derive(Debug, Default, Copy, Clone, PartialEq)] | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep it experimental by removing it from the
builtin()function (like we do forType::ComponentFactory) (or not adding it in the first place by adding a parametter to this function to only add it if experimental)