partial_renderer: Separate the geometry from the rendering to compute dirtyness #9467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: |
ogoffart
force-pushed
the
olivier/swrenderer
branch
from
2d3d266 to
078c224
Compare
|
This is dangerous, I hope i didn't break anything. |
I was thinking the same. It should be relatively fast anyway. |
ogoffart
force-pushed
the
olivier/swrenderer
branch
2 times, most recently
from
88a5796 to
c880ecf
Compare
|
New patch that do no longer have two tracker, but just one for the rendering: The result is that As for the test failure, this is because has a coordinate that isNaN and before, it would rely on the tracker to figure out what changed. But now, it relies on the != operator between bounding rect. And NaN is never equal to itself.
|
ogoffart
force-pushed
the
olivier/swrenderer
branch
2 times, most recently
from
8137d32 to
804f731
Compare
|
The actual reason why this was slower and taking more memory was because we were still visiting clipped (invisible) items. After that being fixed, we are much faster. Now with the latest change from this patch: Master without this patch |
…acker This way we avoid rendering when only the layout is dirty but didn't actually change
We just always query all the geometry anyway
Since every renderer is now always clipping the text, we don't need to account for out of bound drawing. The other optimization of trying not to draw things if the bounding box is smaller is not really a good one since computing the bounding box is itself too expensive and not cached.
No chance we find something dirty there
It uses NaN in one of the coordinate. It used to be fine because we would rely on the tracker to know if anything had changed. But now that we always compare the rectangle and NaN is always != NaN, we would redraw too much for this test
ogoffart
force-pushed
the
olivier/swrenderer
branch
from
804f731 to
8c5c28f
Compare
tronical
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way when a layout is dirty because some text inside changed, we don't redraw the whole screen if most item don't move.
(PR best viewed commit by commit)