Skip to content

Fix recursion panic when PopupWindow.show() called in init callback (#9498) #9523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix recursion panic when PopupWindow.show() called in init callback (#9498) #9523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18b198b
Fix recursion panic when PopupWindow.show() called in init callback (…
Rishant12220055 Sep 25, 2025
8bf6831
Merge branch 'slint-ui:master' into fix-popup-init-recursion-9498
Rishant12220055 Sep 25, 2025
99c782c
[autofix.ci] apply automated fixes
autofix-ci[bot] Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions api/cpp/include/slint_window.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@
auto popup_dyn = popup.into_dyn();
auto id = cbindgen_private::slint_windowrc_show_popup(&inner, &popup_dyn, p, close_policy,
&parent_item, false);
popup->user_init();
// Defer user_init to prevent recursion when init callbacks call popup.show()
cbindgen_private::slint_post_event([popup](void *) { popup->user_init(); }, nullptr,

Check failure on line 97 in api/cpp/include/slint_window.h

View workflow job for this annotation

GitHub Actions / cpp_cmake (macos-14, 1.85) 

'this' argument to member function 'user_init' has type 'const todo_ui::Component_confirm_popup_173', but function is not marked const
nullptr);
return id;
}

Expand Down Expand Up @@ -123,7 +125,9 @@
auto id = cbindgen_private::slint_windowrc_show_popup(
&inner, &popup_dyn, pos, cbindgen_private::PopupClosePolicy::CloseOnClickOutside,
&context_menu_rc, true);
popup->user_init();
// Defer user_init to prevent recursion when init callbacks call popup.show()
cbindgen_private::slint_post_event([popup](void *) { popup->user_init(); }, nullptr,

Check failure on line 129 in api/cpp/include/slint_window.h

View workflow job for this annotation

GitHub Actions / cpp_cmake (macos-14, 1.85) 

'this' argument to member function 'user_init' has type 'const todo_ui::PopupMenuImpl_root_179', but function is not marked const

Check failure on line 129 in api/cpp/include/slint_window.h

View workflow job for this annotation

GitHub Actions / cpp_cmake (macos-14, 1.85) 

'this' argument to member function 'user_init' has type 'const todo_ui::PopupMenuImpl_root_179', but function is not marked const
nullptr);
return id;
}

Expand Down
18 changes: 16 additions & 2 deletions internal/compiler/generator/rust.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2912,7 +2912,14 @@ fn compile_builtin_function_call(
false, // is_menu
))
);
#popup_window_id::user_init(popup_instance_vrc.clone());
// Defer user_init to prevent recursion when init callbacks call popup.show()
let popup_instance_vrc_for_init = popup_instance_vrc.clone();
if let Err(_) = i_slint_core::api::invoke_from_event_loop(move || {
#popup_window_id::user_init(popup_instance_vrc_for_init);
}) {
// Fallback: if event loop is not available (e.g., during testing), call synchronously
#popup_window_id::user_init(popup_instance_vrc.clone());
}
})
} else {
panic!("internal error: invalid args to ShowPopupWindow {arguments:?}")
Expand Down Expand Up @@ -2991,7 +2998,14 @@ fn compile_builtin_function_call(
true, // is_menu
);
#set_id;
#popup_id::user_init(popup_instance_vrc);
// Defer user_init to prevent recursion when init callbacks call popup.show()
let popup_instance_vrc_for_init = popup_instance_vrc.clone();
if let Err(_) = i_slint_core::api::invoke_from_event_loop(move || {
#popup_id::user_init(popup_instance_vrc_for_init);
}) {
// Fallback: if event loop is not available (e.g., during testing), call synchronously
#popup_id::user_init(popup_instance_vrc);
}
};

let common_init = quote! {
Expand Down
Loading