fix: prevent orphan Claude processes when using native binary #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Claude Code is installed as a native binary (not npm), the launcher spawns it as a child process. If the launcher receives SIGTERM/SIGINT, it would exit without forwarding the signal, leaving the Claude binary running as an orphan (PPID becomes 1). This adds signal forwarding in two places: - claude_version_utils.cjs: forwards signals when spawning binary Claude - sdk/query.ts: adds SIGTERM/SIGINT handlers to cleanup spawned processes Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <[email protected]> Co-Authored-By: Happy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When Claude Code is installed as a native binary (via native installer, not npm), the launcher spawns it as a child process. If the parent process receives SIGTERM/SIGINT (e.g., when switching modes or aborting), it would exit without forwarding the signal to the child. This leaves Claude binary processes running as orphans (PPID becomes 1), consuming memory indefinitely.
Solution
Added signal handlers in two places:
scripts/claude_version_utils.cjs- forwards SIGTERM/SIGINT to spawned binary childsrc/claude/sdk/query.ts- adds signal handlers alongside existing cleanup logicTest plan
ps aux | grep claude)🤖 Generated with Claude Code