fix(rtu): replace decode loop with rolling buffer scan#361
Open
obayemi wants to merge 1 commit intoslowtec:mainfrom
Open
fix(rtu): replace decode loop with rolling buffer scan#361obayemi wants to merge 1 commit intoslowtec:mainfrom
obayemi wants to merge 1 commit intoslowtec:mainfrom
Conversation
Never mutate buffer during scanning — use read-only slices to check all byte offsets for valid CRC-confirmed frames. Always return Ok(None) instead of Err to keep FramedRead stream alive with partial data. Add tests for fragmented arrival, back-to-back frames, garbage with valid function codes but bad CRC, partial frame preservation, all-garbage buffers, no Err on excessive garbage, and deep frame recovery.
d607894 to
7a99941
Compare
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implemention of RTU server has some issues in real world situations:
this made the implementation unusable for buses with multiple other slaves.
this PR does:
Never mutate buffer during scanning — use read-only slices to check all byte offsets for valid CRC-confirmed frames. Always return Ok(None) instead of Err to keep FramedRead stream alive with partial data.
Add tests for fragmented arrival, back-to-back frames, garbage with valid function codes but bad CRC, partial frame preservation, all-garbage buffers, no Err on excessive garbage, and deep frame recovery.