-
Notifications
You must be signed in to change notification settings - Fork 276
Revised build environment track files #1537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Revised build environment track files #1537
Conversation
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
marcelamelara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mcevoy-building7 ! I've mostly got smaller edits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this file is being removed altogether? Is the idea to replace it with the new build-verification.md file below?
|
|
||
| **About this page:** the *Build Environment Track: Basics* page defines its levels, describes their security objectives and general requirements. | ||
|
|
||
| **Intended audience:** {add appropriate audience} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Intended audience:** {add appropriate audience} | |
| **Intended audience:** Infrastructure providers (i.e., build platform and compute platform admins), software consumers with very strict security requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paveliak wdyt? Are we missing any other audiences here?
|
|
||
| **Intended audience:** {add appropriate audience} | ||
|
|
||
| **Topics covered:** build track terminology, threats to build environments, explaination for build environment model, level specifics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Topics covered:** build track terminology, threats to build environments, explaination for build environment model, level specifics | |
| **Topics covered:** build environment track terminology, threats to build environments, a model for build environments, level specifics |
| ## What the Build Environment Track does | ||
|
|
||
| <p align="center"><img src="images/build-env-model.svg" alt="Build Environment Model"></p> | ||
| {clean} The SLSA [Build track] defines requirements for the provenance that is produced for the build artifacts. Trustworthiness of the build process largely depends on the trustworthiness of the [build environment] the build runs in. The Build track assumes full trust into the [Build Platform], and provides no requirements to verify integrity of the build environment. BuildEnv track intends to close this gap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
| {clean} The SLSA [Build track] defines requirements for the provenance that is produced for the build artifacts. Trustworthiness of the build process largely depends on the trustworthiness of the [build environment] the build runs in. The Build track assumes full trust into the [Build Platform], and provides no requirements to verify integrity of the build environment. BuildEnv track intends to close this gap. | |
| {clean} The SLSA [Build track] defines requirements for the provenance that is produced for the build artifacts. Trustworthiness of the build process largely depends on the trustworthiness of the [build environment] a build runs in. The Build track assumes full trust in the [Build Platform], and provides no requirements to verify the integrity of the build environment. The BuildEnv track intends to close this gap. |
| For the example threats refer to the [Build Threats] section. | ||
| For the example threats, refer to the [Build Threats] section. | ||
|
|
||
| ## Build environment concept model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this section should come at least before the threats, because we think it's difficult to understand some of the threats and requirements of this track without this important background.
| L3 provides evidence of continuous integrity of the build environment for the whole lifetime. | ||
| TEE technologies are not infallible, so physical human access to hardware and side channel attacks are still a risk that is accepted at L3. | ||
|
|
||
| ### Build image lifetimes diagram |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section has quite a bit of overlap with the build environment model (this was an issue we already had noted before these revisions), so I think we should just move this diagram / mini-section to the build environment model section.
Build Environment Track
File: build-env-track-basics.md
These track files have a new header block structure to provide a consistent table of contents to help users improve navigation and easily identify key details for each page. This will also help spec writers ensure that their information is complete and organized.
Additional edits have been made to headings and content to increase the logic flow and add clarity to each page.
DO NOT MERGE