Skip to content

Don't set the PROVENANCE_AVAILABLE since date to Now() #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puerco merged 1 commit into from
Aug 2, 2025
Merged

Don't set the PROVENANCE_AVAILABLE since date to Now() #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/attest/provenance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,14 @@ func (pa ProvenanceAttestor) createCurrentProvenance(ctx context.Context, commit
curProvPred.Controls = controlStatus.Controls

// At the very least provenance is available starting now. :)
curProvPred.AddControl(&provenance.Control{Name: slsa.ProvenanceAvailable.String(), Since: timestamppb.New(curTime)})
// ... indeed, but don't set the `since`` date because doing so breaks
// checking against policies.
// See https://github.com/slsa-framework/slsa-source-poc/issues/272
curProvPred.AddControl(
&provenance.Control{
Name: slsa.ProvenanceAvailable.String(),
},
)

return addPredToStatement(&curProvPred, provenance.SourceProvPredicateType, commit)
}
Expand Down
Loading